Skip to content

[Docs] Grammatical change / Timer#1457

Merged
ide merged 4 commits intofacebook:masterfrom
christopherdro:timer-doc-fix
May 31, 2015
Merged

[Docs] Grammatical change / Timer#1457
ide merged 4 commits intofacebook:masterfrom
christopherdro:timer-doc-fix

Conversation

@christopherdro
Copy link
Copy Markdown
Contributor

No description provided.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 30, 2015
Comment thread docs/Timers.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a lot of hard tracking down bugs." could use rephrasing

Oddly enough, adding `work` was the first change I wanted to do. :)
@brentvatne
Copy link
Copy Markdown
Collaborator

Maybe we can add in parens after bare timers (setTimeout(...)) and after this mixin (this.setTimeout(...))? Just to be super-extra-clear. Thoughts @christopherdro?

@christopherdro
Copy link
Copy Markdown
Contributor Author

@brentvatne Sounds good.
I just tried narrowing it down even further. I feel like the paragraph above already gave a pretty good breakdown. Feel free make any changes you see fit.

@brentvatne
Copy link
Copy Markdown
Collaborator

We strongly discourage using the global setTimeout(...) and recommend instead that you use this.setTimeout(...) provided by react-timer-mixin. This will eliminate a lot of hard work tracking down bugs, such as crashes caused by timeouts firing after a component has been unmounted.

@christopherdro
Copy link
Copy Markdown
Contributor Author

👍

@ide
Copy link
Copy Markdown
Contributor

ide commented May 31, 2015

That reads nicely. Let's publish it.

ide pushed a commit that referenced this pull request May 31, 2015
[Docs] Grammatical change / Timer
@ide ide merged commit 69ce448 into facebook:master May 31, 2015
mganandraj pushed a commit to mganandraj/react-native that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants